-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving Repository Management feature as a hidden experimental feature. #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding the Repository tool * WIP * View is set up. Test ata as well. * Aligning columns. Adding column spacing. * Reverting this change * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Strings/en-us/Resources.resw Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Adressing comments * Revert "Reverting this change" This reverts commit 711dd78. * Moving to experimental * Disabling by default * Removing from experimental. Addressing comments. * Reverting to main * Update tools/RepositoryManagement/DevHome.RepositoryManagement/DevHome.RepositoryManagement.csproj Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Extensions/ServiceExtensions.cs Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Removing duplicate xaml code * Adding to the mermaid diagram * Got lost in the shuffle * Removing a refrence --------- Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
* WIP * EF works. Can save data. * Can read and write. :) * Repos are added when cloned. * Putting save/load into a different class * Adding default values * Cleaning up names and using statements * More comments * Removing refrence to the public nuget * Restoring the nuget config * Adding a test. Better defining dates * Adding some tests * More comments. * Better path comparison. * Removing unused equals code * Adding more comments. Making new migrations
…thub.com/microsoft/devhome into user/dhoehna/RepositoryManagementFeature
huzaifa-d
reviewed
Aug 29, 2024
database/DevHome.Database/DatabaseModels/RepositoryManagement/RepositoryMetadata.cs
Show resolved
Hide resolved
database/DevHome.Database/DatabaseModels/RepositoryManagement/RepositoryMetadata.cs
Show resolved
Hide resolved
database/DevHome.Database/Migrations/DevHomeDatabaseContextModelSnapshot.cs
Show resolved
Hide resolved
tools/RepositoryManagement/DevHome.RepositoryManagement/DevHome.RepositoryManagement.csproj
Show resolved
Hide resolved
bbonaby
reviewed
Aug 29, 2024
...oryManagement/DevHome.RepositoryManagement/Services/RepositoryManagementDataAccessService.cs
Outdated
Show resolved
Hide resolved
...oryManagement/DevHome.RepositoryManagement/Services/RepositoryManagementDataAccessService.cs
Show resolved
Hide resolved
database/DevHome.Database/Migrations/DevHomeDatabaseContextModelSnapshot.cs
Show resolved
Hide resolved
database/DevHome.Database/Migrations/DevHomeDatabaseContextModelSnapshot.cs
Show resolved
Hide resolved
bbonaby
approved these changes
Sep 3, 2024
kanismohammed
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
After talking to both side I decided that moving this into main is simpler than keeping up a feature branch and dealing with a huge PR at the end.
This PR is to move the Repository Management page into main. However, only dev builds will see the option to enable this feature.
Before this becomes enabled and is taken out of experimental everything will have proper try/catch, logs, and telemetry. Moving the code incrementally into main is simpler than waiting for a giant feature branch merge.
The majority of changes have been reviewed in #3538 and #3536
This change adds modifications to NavConfig for adding this as an experimental feature.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist