-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more information to DevDiagnostics resource usage page #3755
Conversation
result = CommonHelper.GetLocalizedString("ConnectionSpeedSensorValue1Gbps"); | ||
break; | ||
default: | ||
if (_sensor.Value < 1024) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps define all these magic numbers as consts somewhere? #Resolved
<TreeViewItem AutomationProperties.Name="{x:Bind Name}"> | ||
<Grid> | ||
<Grid.ColumnDefinitions> | ||
<ColumnDefinition Width="200"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always going to be big enough, if the user has text size set to >100%? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. No it won't be big enough if the text size gets bigger. Is there a recommended way to set the width? I noticed that with text size increased, the column for current "cpu usage", "memory usage" is not big enough either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we could adjust the width dynamically using UISettings.TextScaleFactor as a multiplier - but that seems overkill. Alternatively, set TextWrapping=wrap, but that might look odd. Simplest would be to simply pick a much bigger width (say 300?), as we have lots of horizontal real estate to play with - not perfect, but likely would cover most cases.
tools/DevDiagnostics/DevHome.DevDiagnostics/Pages/SystemResourceUsagePage.xaml
Show resolved
Hide resolved
Please can you clarify:
|
Have you validated that the resource usage is read by narrator, as well as the tabsd at the top? #Resolved |
UpdateSensorData(node); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale code, will clean #Resolved
Added tooltip information to page header. In reply to: 2327983675 |
Narrator recognizes resource usage and treeview, but it wasn't able to read the tabs. I filed this bug to track the tab header accessibility issue.: #3766 I'll fix it in the next PR. In reply to: 2329804070 |
it might be as simple as adding an x:uid and something like the following to the resources.resw In reply to: 2330275851 |
Thanks! I was having trouble having narrator read the header text block, but after adding uid and AutomationProperties in resource.resw for the tabitem it worked. I'll close the bug. In reply to: 2330307374 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of the pull request
Extend DevDiagnostics's resource usage page to have both system resource usage information and Application resource information.
References and relevant issues
#3296