Hyper-V extension: Check guest OS version before apply configuration. #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbonaby
reviewed
Sep 10, 2024
extensions/HyperVExtension/src/HyperVExtension/Exceptions/GuestOsVersionException.cs
Show resolved
Hide resolved
extensions/HyperVExtension/src/HyperVExtension/Exceptions/GuestOsVersionException.cs
Show resolved
Hide resolved
extensions/HyperVExtension/src/HyperVExtension/Models/HyperVVirtualMachine.cs
Show resolved
Hide resolved
extensions/HyperVExtension/src/HyperVExtension/Strings/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
extensions/HyperVExtension/src/HyperVExtension/CommunicationWithGuest/GuestKvpChannel.cs
Show resolved
Hide resolved
bbonaby
approved these changes
Sep 11, 2024
bbonaby
approved these changes
Sep 11, 2024
huzaifa-d
approved these changes
Sep 12, 2024
huzaifa-d
approved these changes
Sep 12, 2024
bbonaby
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This change adds a check for the guest OS platform and version in "apply configuration" operation for a Hyper-V VM. If VM is not a Windows VM 19041+ the operation will be aborted with "This operation is not supported for the guest OS" message.
We should disable configure environment operation in UI for VMs that don't support it. The work will be in a separate change. (This implementation of getting guest OS version requires the VM to be running, not good for UX where VMs are in a not running state)
Fix an off-by-one bug that was causing #3664.
References and relevant issues
#3662
#3663
#3664
Detailed description of the pull request / Additional comments
Validation steps performed
Tested with Windows and Ubuntu OS's.
PR checklist