[File Explorer Git Integration] Trim version control properties to 80 chars. #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultRyan
force-pushed
the
user/defaultryan/trim-git-properties
branch
from
ea6b59a
to
9272d1a
Compare
krschau
approved these changes
Sep 11, 2024
ssparach
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Trim version control properties to a "reasonable" length, so as to avoid bombarding File Explorer with massively long strings that adversely affect the user experience.
Detailed description of the pull request / Additional comments
Also combined the property filtering logic into a single method used by both property sources.
PR checklist