Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect if the current process is elevated in Dashboard #3833

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

jaholme
Copy link
Contributor

@jaholme jaholme commented Sep 10, 2024

Summary of the pull request

Detect if the current process is elevated instead of whether the user… is in the administrator group for showing the Dashboard
If the user is running in a split token session (typical behavior for an administrator account with UAC enabled) the Widgets provider is running non-elevated and COM callbacks running in Dev Home(elevated) will not work.

However, if the user is running with UAC disabled and running everything as administrator by default Widgets service will also be running with the same token.

This change switches from detecting whether Dev Home is running as a user with the administrator SID to a check that determines if there is a split token for elevation.

For an account with UAC enabled Widgets will still not work:
image

However, for a device with UAC disabled running as admin they work:
image

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

… is in the administrator group for showing the Dashboard
@jaholme jaholme requested review from guimafelipe, krschau, timkur and bbonaby and removed request for bbonaby September 10, 2024 23:08
Copy link
Contributor

@timkur timkur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jaholme jaholme merged commit f96f181 into main Sep 13, 2024
4 checks passed
@krschau krschau added this to the Dev Home v0.19 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants