DevDiagnostics - Move the enablement of local watson collection to a separate process #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkur
requested review from
xhan65,
aeloros,
jaholme,
andreww-msft,
dabhattimsft and
zadesai
|
|
||
| namespace DevHome.DevDiagnostics.Helpers; | ||
|
|
||
| internal sealed class WERUtils |
There was a problem hiding this comment.
No exception handling in this class, nor in its caller...?
There was a problem hiding this comment.
No, if it fails, something bad has happened... not much we can do to recover.
There was a problem hiding this comment.
Right, but log before we failfast?
There was a problem hiding this comment.
I'm not sure where/what I would log. If I'm unable to read the registry, the exception will bubble up to either DevDiagnostics or EnableLocalCabCollection and result in a Watson crash.
Same goes with the writing.... it would fail if this is called from a medium IL context, but should work elevated. If I'm wrong, there will be a Watson crash to track the failure.
andreww-msft
approved these changes
Sep 11, 2024
jaholme
reviewed
Sep 11, 2024
tools/DevDiagnostics/DevHome.DevDiagnostics/ViewModels/WERPageViewModel.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The original implementation to enable local WER collection for an app involved having to relaunch DevDiagnostics elevated. This lead to some clumsy UX...
This cleans up the UX a bit, and to enable/disable local WER collection, will launch a separate app that will require a UAC.
It's not perfect yet, and definitely looking to Design to help clean this up further.
References and relevant issues
Detailed description of the pull request / Additional comments
To help facilitate some code sharing between the standalone exe and DevDiagnostics, I ended up creating a shared WERUtils.cs that was used to read/enable/disable local cab collection.
Validation steps performed
Enabled/disabled WER collection. Confirmed Narrator works for the updates (I end up having Narrator read the tooltip for the button when the user selects it).
PR checklist