GitExecute changes for WSL #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbonaby
reviewed
Sep 12, 2024
extensions/GitExtension/FileExplorerGitIntegration/Models/WslIntegrator.cs
Outdated
Show resolved
Hide resolved
DefaultRyan
requested changes
Sep 12, 2024
extensions/GitExtension/FileExplorerGitIntegration/Models/WslIntegrator.cs
Outdated
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration.UnitTest/WslIntegratorUnitTests.cs
Outdated
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration.UnitTest/WslIntegratorUnitTests.cs
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration.UnitTest/WslIntegratorUnitTests.cs
Outdated
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration.UnitTest/WslIntegratorUnitTests.cs
Outdated
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration.UnitTest/WslIntegratorUnitTests.cs
Outdated
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration/Models/WslIntegrator.cs
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration/Models/GitExecute.cs
Outdated
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration/Models/GitExecute.cs
Outdated
Show resolved
Hide resolved
DefaultRyan
requested changes
Sep 18, 2024
extensions/GitExtension/FileExplorerGitIntegration/Models/GitExecute.cs
Outdated
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration/Models/WslIntegrator.cs
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration.UnitTest/WslIntegratorUnitTests.cs
Outdated
Show resolved
Hide resolved
DefaultRyan
reviewed
Sep 18, 2024
extensions/GitExtension/FileExplorerGitIntegration/Models/WslIntegrator.cs
Show resolved
Hide resolved
DefaultRyan
reviewed
Sep 18, 2024
extensions/GitExtension/FileExplorerGitIntegration.UnitTest/WslIntegratorUnitTests.cs
Outdated
Show resolved
Hide resolved
DefaultRyan
approved these changes
Sep 19, 2024
vineeththomasalex
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR modifies the arguments used while starting a process inside GitExecute to accommodate obtaining git information for WSL repositories.
References and relevant issues
Detailed description of the pull request / Additional comments
This PR adds:
This PR modifies GitExecute to invoke wsl.exe with the expected arguments to obtain git information for registered wsl repository paths.
Validation steps performed
Package build
Unit Tests
Manual testing including registration of repositories inside Dev Home for the git extension
PR checklist