Propagate error info from Hyper-V manager to the callers and telemetry for configuration operation #3865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y for configuration operation
huzaifa-d
reviewed
Sep 16, 2024
extensions/HyperVExtension/src/HyperVExtension/Exceptions/HyperVManagerException.cs
Show resolved
Hide resolved
huzaifa-d
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Propagate more error info returned as a result of Hyper-V operations to higher levels and telemetry.
We were losing some error info returned by PowerShell for Hyper-V operations, making it harder to diagnose the failures. This PR adds more diagnostic info to telemetry.
References and relevant issues
#3662
Detailed description of the pull request / Additional comments
I haven't seen a useful HRESULT in exceptions returned by PowerShell, however error description can be useful and can have error codes embedded into the text.
Validation steps performed
Tested by forcing Hyper-V/PowerShell to return errors when trying to execute Configure Environment operation.
PR checklist