User/krschau/fix ssh widget crash #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
reviewed
Sep 25, 2024
dhoehna
reviewed
Sep 25, 2024
tools/Dashboard/DevHome.Dashboard/ViewModels/WidgetViewModel.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Sep 25, 2024
tools/Dashboard/DevHome.Dashboard/ViewModels/WidgetViewModel.cs
Outdated
Show resolved
Hide resolved
krschau
merged commit 88f5eb8
into
user/lcihafelipeda/fix-ssh-widget-crash
4 checks passed
lauren-ciha
added a commit
that referenced
this pull request
Sep 26, 2024
* Prevent crash with catch statement * Update HandleConnect for new args.Data structure * Refactor JSON string wrapping * Clean up styling * Remove Newtonsoft dependency from SSHWalletWidget * User/krschau/fix ssh widget crash (#3900) --------- Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
EricJohnson327
pushed a commit
that referenced
this pull request
Oct 1, 2024
* Prevent crash with catch statement * Update HandleConnect for new args.Data structure * Refactor JSON string wrapping * Clean up styling * Remove Newtonsoft dependency from SSHWalletWidget * User/krschau/fix ssh widget crash (#3900) --------- Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist