Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[File Explorer Source Control Integration] Accessibility bug fixes #3906

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

ssparach
Copy link
Contributor

@ssparach ssparach commented Sep 27, 2024

Summary of the pull request

This PR fixes two accessibility bugs for the File Explorer Page under Windows Customization.

References and relevant issues

https://microsoft.visualstudio.com/OS/_workitems/edit/53874018
https://microsoft.visualstudio.com/OS/_workitems/edit/53873865

Detailed description of the pull request / Additional comments

The accessibility bugs that this PR resolves are:

  • On navigating to 'Unassigned' button (dropdown) or 'More options' button, narrator is not announcing position count for the list items. Arrow navigation is defined for 'Folder paths' so position count should be defined.
  • On navigating to 'Unassigned' button (dropdown), narrator is announcing as 'Unassigned button collapsed' but it is not announcing its respective 'Folder path'.

Validation steps performed

Used narrator to confirm that the following expected results were achieved:

  • Position count defined on navigating to the dropdown button or 'More options' button i.e. narrator announces if an item is one of two, two of four etc.
  • Narrator announces the associated folder path info on navigating to dropdown button

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@ssparach ssparach marked this pull request as ready for review September 30, 2024 18:56
@@ -40,15 +40,20 @@
Orientation="Horizontal">
<DropDownButton
Content="{Binding SourceControlProviderDisplayName}"
ToolTipService.ToolTip="{Binding SourceControlProviderPackageDisplayName}">
AutomationProperties.Name="{Binding RepoPathMapping}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this set the name correctly (does it sound right in Narrator / look right in acc insights/inspect) or don't you need to do the
<data name="ButtonName.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve"> thing in the resw file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does seem to set the name correctly. In narrator, the path is correctly announced with backslashes, followed by the status of the drop down button. I also checked with Accessibility Insights and it did not flag any issues. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting a binding for the automation name is needed when something has to change between all the items. For example, in RepoConfig. The narrator says for the edit button "Edit repository [path]" where path is different for each item.

@krschau krschau added this to the Dev Home v0.19 milestone Oct 2, 2024
@ssparach ssparach merged commit 5b6c362 into main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants