Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified SDK for Quickstart Playground - Chat Style #3908

Closed
wants to merge 4 commits into from

Conversation

chenss3
Copy link
Contributor

@chenss3 chenss3 commented Sep 28, 2024

Summary of the pull request

Introduces SDK changes needed for the Chat Style integration of Quickstart Playground

References and relevant issues

Detailed description of the pull request / Additional comments

  • Does not modify the existing Quickstart playground provider and creates a new one that we will then modify
  • Adds QuickStartChatStyleResult response object

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

[experimental]
[contract(Microsoft.Windows.DevHome.SDK.DevHomeContract, 6)]
runtimeclass QuickStartChatStyleResult
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think we want a class to provide flexibility for the chat result for the future rather than just using string below in the async operation?

@dhoehna
Copy link
Contributor

dhoehna commented Oct 1, 2024

Do you have a link to the API review?

@chenss3
Copy link
Contributor Author

chenss3 commented Oct 1, 2024

Do you have a link to the API review?

Good question! It is in the works. I had just sent mail out to Hart about this

@chenss3 chenss3 closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants