Modified SDK for Quickstart Playground - Chat Style #3908
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Sep 28, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Sep 28, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Sep 28, 2024
| // This allows to have an async operation can be started but also additional context reported back to Dev Home | ||
| // as progress is being made such as a detailed log out output through the adaptive card session. | ||
| [experimental] | ||
| [contract(Microsoft.Windows.DevHome.SDK.DevHomeContract, 6)] |
There was a problem hiding this comment.
Do we need to increment contract version throughout.
There was a problem hiding this comment.
Sarah stated in a previous thread: If the contract version is being incremented here, we may also need to change the VersionOfSDK value inside build/azure-pipelines.yml.
There was a problem hiding this comment.
I believe I saw the current contract version is 7, so I updated all of the new ones I'm adding in to be contract version 8.
manodasanW
reviewed
Sep 28, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Sep 28, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Show resolved
Hide resolved
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Introduces SDK changes needed for the Chat Style integration of Quickstart Playground
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist