Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/prepare xaml pages for additional changes #3910

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Sep 30, 2024

Summary of the pull request

In preparation for larger changes that are going into the Experimental Features page, Environments Landing page, and SetupFlow MainPage, this PR does some rearranging, cleanup, and whitespace changes. The only functional change is adding a margin to the SetupFlow main page so that each set of SettingsCards is the same distance underneath its header.

Detailed changes broken down by page:

  • ExperimentalFeaturesPage.xaml: whitespace, remove VerticalScrollBarVisibility which was set to the defau.t value anyway.
  • LandingPageViewModel/LandingPage: instead of using the Loaded event, use i:Interaction.Behaviors to call ViewModel's LoadedCommand when the page is loaded.
  • LandingPage.xaml: whitespace
  • MainPageView.xaml: whitespace, fix indentation, simplify Uid references.

References and relevant issues

Validation steps performed

Validated locally.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@krschau krschau added this to the Dev Home v0.19 milestone Sep 30, 2024
@krschau krschau merged commit 5e75f86 into main Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants