[Dev Home]: Keyboard focus goes missing on closing 'Select Folder' window using keyboard #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssparach
requested review from
DefaultRyan,
krschau,
dhoehna and
vineeththomasalex
krschau
approved these changes
Oct 4, 2024
tools/Customization/DevHome.Customization/ViewModels/FileExplorerViewModel.cs
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/ViewModels/FileExplorerViewModel.cs
Show resolved
Hide resolved
vineeththomasalex
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR fixes the following bug:
References and relevant issues
https://microsoft.visualstudio.com/OS/_workitems/edit/53872961
Detailed description of the pull request / Additional comments
During testing, it was observed that focus is also lost when a folder is chosen and the File Explorer window closes.
The fix in this PR ensures that focus is readjusted to the relevant parent UI control after any interaction with File Explorer.
Validation steps performed
Local Build
Unit Tests
Manual testing of fix to confirm focus is regained after the File Explorer window closes
PR checklist