Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[File Explorer Source Control Integration] Accessibility Bug Fixes #3941

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

ssparach
Copy link
Contributor

Summary of the pull request

This PR contains accessibility bug fixes for the following issues:

  • Section headers 'File Explorer+ Version Control' and 'Add Repositories' are not announced by narrator in 'Windows Customization>> File explorer' page.
  • "Error assigning source control provider" is not defined as heading.
  • Tooltip is not defined for "More Options" button in Add repository group

References and relevant issues

https://microsoft.visualstudio.com/OS/_workitems/edit/53873821
https://microsoft.visualstudio.com/OS/_workitems/edit/53874085
https://microsoft.visualstudio.com/OS/_workitems/edit/53874117

Detailed description of the pull request / Additional comments

Validation steps performed

Local Build
Unit Tests
Confirmed the tooltip appears for the "More Options" button in Add Repositories UI
Confirmed the following using narrator:

  • Narrator announces the section headers 'File Explorer+ Version Control' and 'Add Repositories' in 'Windows Customization>> File explorer' page.
  • Narrator conveys the heading level for "Error assigning source control provider"

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@ssparach ssparach requested a review from manodasanW October 11, 2024 22:29
@ssparach ssparach merged commit 9513668 into main Oct 14, 2024
4 checks passed
@krschau krschau added this to the Dev Home v0.19 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants