Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin widget flow #312

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Update pin widget flow #312

merged 2 commits into from
Jan 11, 2024

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Jan 8, 2024

Summary of the pull request

Accommodate the updated pin widget flow from microsoft/devhome#2110. Widgets are selected in the Add widget dialog and configured inline on the Dashboard, similar to how the Windows Widget Board does it.

References and relevant issues

Detailed description of the pull request / Additional comments

  • Since we don't have to communicate to the host that we're in configuration mode anymore, it is removed from the Data json.
  • Since there is no longer a different between "add" configuration state and "edit" configuration state, we can always show the Save and Cancel buttons in the Configuration template, although we only enable Cancel if there was once a valid state we can return to.
  • Change UpdateActivityState() to use override keyword instead of new. By hiding the higher level method, the wrong one was being used. In the old flow, it happened to do the right thing, but wouldn't in the new flow.
  • The Review Requested widget does not have a configure state, so throw an error if we request it.

PR in Draft until we get screenshot assets.

Validation steps performed

PR checklist

@krschau krschau force-pushed the user/krschau/pin-flow branch from 503e920 to 992139a Compare January 9, 2024 22:10
@dkbennett dkbennett added the Needs-Second Pull request that needs another approval label Jan 11, 2024
@EricJohnson327 EricJohnson327 marked this pull request as ready for review January 11, 2024 20:46
@EricJohnson327 EricJohnson327 merged commit 2b12130 into main Jan 11, 2024
4 checks passed
@EricJohnson327 EricJohnson327 deleted the user/krschau/pin-flow branch January 11, 2024 20:46
EricJohnson327 pushed a commit that referenced this pull request Jan 18, 2024
* Update pin flow

* remove less-useful config template fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Second Pull request that needs another approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update widget pin flow
4 participants