Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StyleCop #345

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Update StyleCop #345

merged 1 commit into from
Feb 21, 2024

Conversation

davidegiacometti
Copy link
Contributor

Summary of the pull request

Updated StyleCop to the latest version to improve compatibility with latest .NET/C# feature.

References and relevant issues

Follow-up of microsoft/devhome#2162

Detailed description of the pull request / Additional comments

  • Addressed StyleCop violations after the update
  • Removed obsolete StyleCop suppressions in GlobalSuppressions.cs

Validation steps performed

  • Changes are mostly spaces and new lines and shouldn't have any impact.
  • Verified that the extension build and run as expected when loaded by DevHome.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@krschau krschau added the Needs-Second Pull request that needs another approval label Feb 21, 2024
@EricJohnson327 EricJohnson327 merged commit 201b025 into microsoft:main Feb 21, 2024
4 checks passed
@krschau krschau removed the Needs-Second Pull request that needs another approval label Feb 21, 2024
@krschau krschau added this to the DHGE v0.12 milestone Feb 21, 2024
@davidegiacometti davidegiacometti deleted the stylecop branch February 21, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants