Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save widget default titles #439

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

guimafelipe
Copy link
Contributor

@guimafelipe guimafelipe commented Aug 27, 2024

Summary of the pull request

When the user saves a widget with not title, a default title is displayed for them. For repository widgets, it is the name of the repository. For user widgets, it is the username. This title was being saved in the widget data, but resulted is some QoL issues. This PR makes these default titles to not be saved anymore, and just rendered in the content is loaded to be presented.

References and relevant issues

Detailed description of the pull request / Additional comments

As the issue above describes, when the user saves a repository widget, it sets the title to be its repository's full name. When the user customizes this widget and changes to another repository, the previous title keeps saved, requiring the user to actively change or erase the title.
This default title does not need to be saved as it is a information that we get on time from the widget's information. So it is the best choice to not save it in the widget's data string and just generate the string when it is needed.

Validation steps performed

PR checklist

@krschau krschau changed the title Default titles not saved anymore for widgets Don't save widget default titles Aug 28, 2024
@krschau
Copy link
Collaborator

krschau commented Aug 28, 2024

I renamed the PR since the original wording made it sound like a bug, instead of a fix to the bug.

@guimafelipe guimafelipe merged commit 00d2e88 into main Aug 28, 2024
4 checks passed
@krschau krschau modified the milestone: DHGE v0.18 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update widget title after repo update
3 participants