Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid major windows crate dependency #31

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Avoid major windows crate dependency #31

merged 2 commits into from
Jan 13, 2025

Conversation

kennykerr
Copy link
Collaborator

A few small improvements to clean up dependencies and general structure.

  • Removed the windows crate dependency as this wasn't really necessary and avoids a large dependency for what should be a pretty targeted library crate.
  • I removed the COM initialization from the samples as this simplifies things. This didn't seem to be needed but I'm happy to be wrong.
  • Flattened the public bindings and generate private helper bindings for library loading.

@kennykerr kennykerr requested a review from riverar January 13, 2025 19:34
riverar
riverar approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@riverar riverar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@riverar riverar merged commit de2b975 into master Jan 13, 2025
7 checks passed
@riverar riverar deleted the kenny-cleanup branch January 13, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riverar riverar riverar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kennykerr @riverar