Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md updated with latest ModelGeneratorOptions and Prerequisites. #18

Merged
merged 6 commits into from
Oct 20, 2022
Merged

README.md updated with latest ModelGeneratorOptions and Prerequisites. #18

merged 6 commits into from
Oct 20, 2022

Conversation

NancyGargMS
Copy link
Contributor

README.md has been updated with prerequisites section for Model Generator. Further, ModelGeneratorOptions section of ReadMe has been updated as per the current properties of the class.

@NancyGargMS NancyGargMS marked this pull request as ready for review August 31, 2022 07:24
@NancyGargMS NancyGargMS requested a review from a team as a code owner August 31, 2022 07:24
@nilay-kapadia nilay-kapadia self-requested a review September 6, 2022 16:57
jarz
jarz reviewed Sep 6, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Sep 13, 2022

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ NancyGargMS sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

jarz
jarz previously approved these changes Sep 13, 2022
View reviewed changes
nilay-kapadia
nilay-kapadia previously approved these changes Sep 13, 2022
View reviewed changes
ms-mikeb
ms-mikeb requested changes Sep 14, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@NancyGargMS NancyGargMS dismissed stale reviews from nilay-kapadia and jarz via a090712 September 22, 2022 06:09
@ms-mikeb ms-mikeb added status:in-progress Someone is working on implementation type:docs Documentation labels Oct 11, 2022
ms-mikeb
ms-mikeb previously approved these changes Oct 12, 2022
View reviewed changes
nilay-kapadia
nilay-kapadia previously approved these changes Oct 12, 2022
View reviewed changes
@NancyGargMS @jarz
Add support for duration primitive (#19) (#20)
05e3d9e 
* Add support for Duration properties on DTDL models
* Add support for a map with duration values

Co-authored-by: Tim Jarzombek <timjarzombek@microsoft.com>
@NancyGargMS NancyGargMS dismissed stale reviews from nilay-kapadia and ms-mikeb via 05e3d9e October 13, 2022 07:47
@NancyGargMS
Revert "Add support for duration primitive (#19)" (#21)
ac0ea09 
Revert "Add support for duration primitive (#19) (#20)"

This reverts commit 05e3d9e.
@NancyGargMS NancyGargMS merged commit dea17cb into main Oct 20, 2022
@NancyGargMS NancyGargMS linked an issue Oct 20, 2022 that may be closed by this pull request
[Docs]: Need to update README to be clearer about what is or is not supported and what limitations the generator has #15
Closed
@NancyGargMS NancyGargMS linked an issue Oct 31, 2022 that may be closed by this pull request
[Feature]: Support for date primitive type #17
Closed
@NancyGargMS NancyGargMS removed a link to an issue Oct 31, 2022
[Feature]: Support for date primitive type #17
Closed
@NancyGargMS NancyGargMS deleted the users/nancygargms/init branch October 31, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chpence chpence chpence approved these changes

@jarz jarz jarz approved these changes

@nilay-kapadia nilay-kapadia nilay-kapadia left review comments

@ms-mikeb ms-mikeb ms-mikeb left review comments

Assignees

@NancyGargMS NancyGargMS

Labels
status:in-progress Someone is working on implementation type:docs Documentation
Projects
None yet
Milestone
No milestone
5 participants
@NancyGargMS @jarz @ms-mikeb @chpence @nilay-kapadia