This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
For $ExpectType assertions, alphabetically sort unions and intersections #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
mentioned this pull request
|
There's going to be an immediate limitation with type literals containing unions (i.e. |
|
I didn't see a lot, so added code to just skip anything with an object literal in it for now. |
DanielRosenwasser
suggested changes
Aug 27, 2017
src/rules/expectRule.ts
Outdated
| @@ -308,6 +309,27 @@ function getExpectTypeFailures( | |||
| } | |||
| } | |||
|
|
|||
| function fixupType(s: string): string { | |||
| // Don't mess up `{ a: number | string }` into `string } | { a: number` | |||
| if (s.includes("{")) { | |||
|
If we don't expect this to work perfectly, why not try to see if the current ones are identical, then try the adjustment as a fallback mechanism? Does that sound reasonable? |
fbartho
reviewed
Apr 11, 2018
| @@ -298,7 +298,12 @@ function getExpectTypeFailures( | |||
|
|
|||
| const actual = checker.typeToString(type, /*enclosingDeclaration*/ undefined, ts.TypeFormatFlags.NoTruncation); | |||
| if (actual !== expected) { | |||
| unmetExpectations.push({ node, expected, actual }); | |||
| console.log("!!!", actual); | |||
There was a problem hiding this comment.
Debug logs probably need to be cleaned up in this method/if-block?
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a perfect solution to microsoft/TypeScript#17944 as it operates on strings and thus can't delve into types easily, but should be enough to fix our test failures for now.
When this is merged I'll have to update all the tests on DT to align with this at the same time this is published.