Use ActivatorUtilities.GetServiceOrCreateInstance for TaskActivity in Azure Functions #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
approved these changes
Jan 9, 2023
|
Also, consider updating CHANGELOG.md as part of this PR. |
|
Testing would be great but having it in a different repo causes the tests to become broken soon as I introduce any breaking change. When/if we move the Azure functions extension package to this repo it will become much simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ActiviatorUtilities.CreateInstance<T>toActivatorUtilities.GetServiceOrCreateInstance<T>inside the source generated code for Azure Functions.resolves #88