Add new TaskOption overload for skipping input param #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+112
to
+118
|
|
||
| /// <returns> | ||
| /// A task that completes when the activity completes or fails. The result of the task is the activity's return value. | ||
| /// </returns> | ||
| /// <inheritdoc cref="CallActivityAsync(TaskName, object?, TaskOptions?)"/> | ||
| public virtual Task CallActivityAsync(TaskName name, TaskOptions options) | ||
| => this.CallActivityAsync(name, null, options); |
There was a problem hiding this comment.
Should we really inherit the docs from the CallActivityAsync with the input parameter?
There was a problem hiding this comment.
Same comment for the changes in CallSubOrchestrator
There was a problem hiding this comment.
To be honest, I don't really know the answer to that. @cgillum suggested I do it on another PR so I did 🤷
There was a problem hiding this comment.
Well, even if this were off, it's a non-blocking concern
davidmrdavid
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
LGTM, although it would be good to hear from @cgillum on the inheritdoc question
|
I will address/review the inheritdoc usages in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some overloads to protect against accidentally supplying
TaskOptionsasinput.