Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples with new packages #211

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

jviau
Copy link
Member

@jviau jviau commented Oct 10, 2023

  • Updates packages
  • Combines Counter.State and Counter.Entity into single file with different start API.

{
// Get access to TaskEntityContext by adding it as a parameter. Can be with or without an input parameter.
// Order does not matter.
context.ScheduleNewOrchestration("SomeOrchestration", "SomeInput");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, this operation is not actually called from anwhere, nor does it call an existing orchestration. It does serve as a syntax sample, but usually our samples demonstrate runnable scenarios.

So it seems a bit out of place compared to the rest of the sample.

Copy link
Member Author

@jviau jviau Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was a syntax sample I threw together just to aid doc creation. We can replace it with a runnable sample later.

@jviau jviau merged commit ac5eb32 into microsoft:feature/entities Oct 11, 2023
@jviau jviau deleted the update-samples branch October 11, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants