Fix inner exception propagation #290
Merged
+220
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
approved these changes
Apr 19, 2024
…into cgillum/functions-2476
davidmrdavid
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fixing Azure/azure-functions-durable-extension#2476
There were various places where we weren't correctly setting the inner failure details for
TaskFailureDetails. This PR fixes those and adds a new test to cover this scenario specifically.Note that this PR depends on updates to DurableTask.Core (Azure/durabletask#1067) and DurableTask.Sidecar (https://github.com/microsoft/durabletask-sidecar/pull/24). I'm not expecting this PR to build until we have the new versions of those packages available.