Initial migration of sidecar code into this repo #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the purpose of GitHub repo and 1ES pipeline consolidation, I'm migrating the contents of the private microsoft/durabletask-sidecar repo into this repo. Once this migration is complete, I will delete the sidecar repo.
The code is mostly unchanged, except for a few changes I had to make to resolve StyleCop and other static analysis build warnings.
The purpose of this code is primarily to use as a test server. It's used by this repo already for the gRPC integration tests, and also used indirectly by the Java repo for its integration tests. It's also used by some internal teams at Microsoft for their .NET Isolated integration tests. Moving it here will make maintaining the code more streamlined and aligned with our more modern engineering practices.
There are two projects being moved into this repo.
There was also a DurableTask.Sidecar.Protobuf project in the old repo. However, this should be replaceable by Microsoft.DurableTask.Grpc, which I've done, so there's no need to migrate it.
There are a few things that I didn't do yet in this PR. For example, the build configuration is a bit different compared to other projects. Things like the common.proj and a separate strong name signing key are different from how all other projects are built and configured. I'm open to changing some of this if I can be provided the right guidance. I'm a bit worried about changing the signing key, however, since that would change the identity of the assembly that already exists in the wild (although shouldn't be being used for anything in production).