Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-register default DurableTaskClient. Fix multiple registrations #81

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Auto-register default DurableTaskClient. Fix multiple registrations #81

merged 1 commit into from
Nov 14, 2022

Conversation

jviau
Copy link
Member

@jviau jviau commented Nov 11, 2022

This PR performs two key changes:

  1. Fixes an issue where we would register multiple DurableTaskClient to the DI container, hampering the ability to directly import a client in the multi-client scenario.
  2. Auto-registers the default client directly to the DI container. This will help the common scenario with default (nameless) DurableTaskClients.

@jviau jviau mentioned this pull request Nov 11, 2022
Merged
@jviau jviau requested a review from cgillum November 11, 2022 19:25
@jviau jviau merged commit 1ce3703 into microsoft:main Nov 14, 2022
@jviau jviau deleted the default-client-di branch November 14, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jviau @cgillum