Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchestration ID reuse policies #51

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Orchestration ID reuse policies #51

merged 4 commits into from
Dec 18, 2023

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Dec 15, 2023

This PR is a follow-up PR for #46. It include some updates to support reuse ID policy in dapr workflow

Related issue #42

create alias for protos type

update test

move duplicate code outside backend implementation

update paramter name
@kaibocai kaibocai marked this pull request as ready for review December 15, 2023 18:04
@kaibocai
Copy link
Member Author

tag @ItalyPaleAle , @RyanLettieri for review.

backend/backend.go Outdated Show resolved Hide resolved
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions from me:

api/orchestration.go Outdated Show resolved Hide resolved
backend/backend.go Outdated Show resolved Hide resolved
tests/orchestrations_test.go Show resolved Hide resolved
@kaibocai kaibocai force-pushed the kaibocai/reuse-id-dapr branch 2 times, most recently from 76c6eeb to fde7991 Compare December 15, 2023 21:50
simplify status check

update tests

clean up

fix test
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad to have this change! Let's wait to merge until the Dapr PR which uses it is also signed off.

@cgillum cgillum changed the title Reuse ID policy support for Dapr workflow Orchestration ID reuse policies Dec 18, 2023
@kaibocai kaibocai merged commit d7bb0ed into main Dec 18, 2023
4 checks passed
@cgillum cgillum deleted the kaibocai/reuse-id-dapr branch December 18, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants