Add dockerfile #56
Merged
Add dockerfile #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
reviewed
Jan 10, 2024
main.go
Outdated
| @@ -15,6 +15,7 @@ import ( | |||
|
|
|||
| var ( | |||
| port = flag.Int("port", 4001, "The server port") | |||
| ip = flag.String("ip", "localhost", "The server IP") | |||
There was a problem hiding this comment.
I think it's more common to use host as the name of the hostname parameter.
Dockerfile
Outdated
|
|
||
| # Run | ||
| ENTRYPOINT [ "/durabletask-go" ] | ||
| CMD [ "--ip", "0.0.0.0" ] |
There was a problem hiding this comment.
Should we make the port number explicit here too since we're hardcoding EXPOSE 4001?
ItalyPaleAle
requested changes
Jan 10, 2024
Dockerfile
Outdated
| @@ -0,0 +1,15 @@ | |||
| # syntax=docker/dockerfile:1 | |||
|
|
|||
| FROM golang:1.21 | |||
There was a problem hiding this comment.
Please use a multi-stage Dockerfile:
- Stage one, from “golang:1.21-alpine” just builds the container
- Stage 2 is the production stage and it’s based on distroless.
Example: https://github.com/GoogleContainerTools/distroless/blob/main/examples/go/Dockerfile
There was a problem hiding this comment.
thanks for this! Updated!
cgillum
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
I'm good with these changes once @ItalyPaleAle's comments are resolved.
ItalyPaleAle
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dockerfile