improve worker shutdown logic #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
cgillum
reviewed
Jul 19, 2024
|
@famarting looks like the unit tests are failing. Can you please take a look? |
|
yes, just noticed, looking at it now |
|
should be ready now |
|
ping |
|
@famarting for some reason, it doesn't look like the latest commit kicked off a PR validation run. Maybe you can try pushing a quick dummy commit to see if that kicks off the tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic for stopping the task worker and improves the logic for draining tasks currently being processed
This should increase the reliability of correctly completing or abandoning tasks that are being processed while a shutdown happens.
Added tests and a new hand made "mock" to help test all of this