Support activity retry policies #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
60 tasks
cgillum
requested changes
Oct 22, 2024
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
cgillum
reviewed
Oct 23, 2024
…task-go into support-retry-policies
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
cgillum
approved these changes
Oct 24, 2024
|
Note that I've updated the title of this PR to clarify that it only covers activity retry policies. Another PR will be needed to cover orchestration retry policies (which cover sub-orchestration scenarios). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required of dapr/go-sdk#541
adds the
ActivityRetryPolicystruct and updates CallActivity to execute a different code path if retries are needed.I tried to mimic the behavior of https://github.com/Azure/durabletask/blob/main/src/DurableTask.Core/RetryInterceptor.cs#L52
but in the case of golang I had to make it a recursive algorithm