Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge instance support #33

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Purge instance support #33

merged 3 commits into from
Apr 21, 2022

Conversation

shreyas-gopalakrishna
Copy link
Member

  • Support for purge instance
  • Added integration tests

closes #10

cgillum
cgillum reviewed Apr 20, 2022
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! My only ask is that we add to these test cases to confirm that the purged instances are really gone.

sdk/src/test/java/com/microsoft/durabletask/IntegrationTests.java Show resolved Hide resolved
sdk/src/test/java/com/microsoft/durabletask/IntegrationTests.java Show resolved Hide resolved
@shreyas-gopalakrishna shreyas-gopalakrishna merged commit ae18755 into main Apr 21, 2022
@shreyas-gopalakrishna shreyas-gopalakrishna deleted the shreyasg/purge-instance branch April 21, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Purge instance support
2 participants
@shreyas-gopalakrishna @cgillum