Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating SqlDurabilityProviderStartup to implement IWebJobsStartup #117

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Updating SqlDurabilityProviderStartup to implement IWebJobsStartup #117

merged 3 commits into from
Aug 12, 2022

Conversation

surgupta-msft
Copy link
Contributor

Updating SqlDurabilityProviderStartup to implement IWebJobsStartup instead of FunctionsStartup. Similar PR merged in another Durable extension - microsoft/durabletask-netherite#186

cgillum
cgillum reviewed Aug 12, 2022
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this PR!

Can we also remove the nuget reference to Microsoft.Azure.Functions.Extensions, now that we're not using the FunctionsStartup attribute?

src/DurableTask.SqlServer.AzureFunctions/SqlDurabilityProviderStartup.cs Outdated Show resolved Hide resolved
cgillum
cgillum approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I did some minor manual testing as well and things seem to be working normally with this change. I will merge it and include it in a v1.0.1 release (I'll do the package update in a separate PR).

@cgillum cgillum merged commit 32f4813 into microsoft:main Aug 12, 2022
@surgupta-msft surgupta-msft mentioned this pull request Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surgupta-msft @cgillum