Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #127 Is not properly using TaskHubName #128

Merged
merged 11 commits into from
Oct 11, 2022

Conversation

bhugot
Copy link
Contributor

@bhugot bhugot commented Sep 17, 2022

Fixed #127 Durability factory when calling for a client is using default TestHubName or DurableTaskOption HubName instead of using the specified TaskHub

…sing default TestHubName or DurableTaskOption HubName instead of using the specified TaskHub
@cgillum cgillum self-assigned this Sep 21, 2022
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I few questions/comments:

@bhugot
Copy link
Contributor Author

bhugot commented Sep 22, 2022

Hello @cgillum I reworked a bit the test so that we also use custom schema.

@bhugot bhugot requested a review from cgillum September 28, 2022 07:06
@bhugot
Copy link
Contributor Author

bhugot commented Oct 10, 2022

Hello @cgillum any news on this?

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, and so sorry for dropping the ball on this PR. My only remaining ask is if we can drop a few things that I don't think are fully necessary. After that, I'm good to accept this.

@bhugot
Copy link
Contributor Author

bhugot commented Oct 10, 2022

All good for me @cgillum

@bhugot
Copy link
Contributor Author

bhugot commented Oct 11, 2022

@cgillum I fixed the test it was timeout due to purge but it's not required in multitenancy tests

@cgillum
Copy link
Member

cgillum commented Oct 11, 2022

It looks like there might be a test concurrency issue now that we have multiple integration test classes . Here's the error from the CI:

Content root path: /home/runner/work/durabletask-mssql/durabletask-mssql/test/DurableTask.SqlServer.AzureFunctions.Tests/bin/Debug/net6.0/
  Failed DurableTask.SqlServer.AzureFunctions.Tests.WithoutMultiTenancyCoreScenarios.MultiInstanceQueries [1 ms]
  Error Message:
   System.Net.Sockets.SocketException : Address already in use

The solution mentioned here might be good to look into.

@bhugot
Copy link
Contributor Author

bhugot commented Oct 11, 2022

Thx for the tips @cgillum was looking at it. could you rerun I hope attribute on CoreScenario is going to work with inheritance

@bhugot
Copy link
Contributor Author

bhugot commented Oct 11, 2022

Great

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, everything looks good. Thank you for this contribution!

@cgillum cgillum merged commit 570eb95 into microsoft:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External client ignores task hub name configuration
2 participants