Skip to content

Making token credential optional #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Making token credential optional #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1cb4e
Making token credential optional
RyanLettieri Mar 10, 2025
3f44f49
Merge branch 'main' into lettieri/optional-token-credential
RyanLettieri Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion durabletask-azuremanaged/durabletask/azuremanaged/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# Licensed under the MIT License.

from azure.core.credentials import TokenCredential
from typing import Optional

from durabletask.azuremanaged.internal.durabletask_grpc_interceptor import \
DTSDefaultClientInterceptorImpl
Expand All @@ -13,7 +14,7 @@ class DurableTaskSchedulerClient(TaskHubGrpcClient):
def __init__(self, *,
host_address: str,
taskhub: str,
token_credential: TokenCredential,
token_credential: Optional[TokenCredential],
secure_channel: bool = True):

if not taskhub:
Expand Down
4 changes: 3 additions & 1 deletion durabletask-azuremanaged/durabletask/azuremanaged/internal/durabletask_grpc_interceptor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# Licensed under the MIT License.

import grpc
from typing import Optional

from azure.core.credentials import TokenCredential

from durabletask.azuremanaged.internal.access_token_manager import \
Expand All @@ -15,7 +17,7 @@ class DTSDefaultClientInterceptorImpl (DefaultClientInterceptorImpl):
StreamUnaryClientInterceptor and StreamStreamClientInterceptor from grpc to add an
interceptor to add additional headers to all calls as needed."""

def __init__(self, token_credential: TokenCredential, taskhub_name: str):
def __init__(self, token_credential: Optional[TokenCredential], taskhub_name: str):
self._metadata = [("taskhub", taskhub_name)]
super().__init__(self._metadata)

Expand Down
3 changes: 2 additions & 1 deletion durabletask-azuremanaged/durabletask/azuremanaged/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# Licensed under the MIT License.

from azure.core.credentials import TokenCredential
from typing import Optional

from durabletask.azuremanaged.internal.durabletask_grpc_interceptor import \
DTSDefaultClientInterceptorImpl
Expand All @@ -13,7 +14,7 @@ class DurableTaskSchedulerWorker(TaskHubGrpcWorker):
def __init__(self, *,
host_address: str,
taskhub: str,
token_credential: TokenCredential,
token_credential: Optional[TokenCredential],
secure_channel: bool = True):

if not taskhub:
Expand Down
Loading