Initial checkin #1
Conversation
Network Console is an experimental UI for creating synthetic HTTP requests from DevTools. It is designed for web API developers and consumers, and is intended to be compatible with similar tools.
In a move to migrate this to a single-file distribution, a necessary component was to add CSP to this application. We've now identified all the locations from which we load web-based sources. A future version may move all of the dependencies directly into the application. Also removed a now-unused build script.
joselea
left a comment
joselea
left a comment
There was a problem hiding this comment.
There are many files so it will take me a while. Initial set of comments
packages/devtools-network-console/src/actions/collections/index.ts
Outdated
Show resolved
Hide resolved
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
Left some thoughts, overall the project seems reasonable and well organized. Mostly nits and minor polish stuff.
Cool tool, happy to see React doing some work for you. Curious how good/bad your devloop was.
|
|
||
| it('renders without crashing', () => { | ||
| const div = document.createElement('div'); | ||
| ReactDOM.render(<App />, div); |
There was a problem hiding this comment.
maybe should be rendering this inside a Strict tag for extra checks?
| ); | ||
| } | ||
|
|
||
| const AUTH_SCHEME_NAME_MAP = new Map<NetworkConsoleAuthorizationScheme, string>([ |
There was a problem hiding this comment.
maybe these maps shouldn't live in the ux component?
There was a problem hiding this comment.
Why? They present UX strings (or the earlier map associates a value to a UX component index).
There was a problem hiding this comment.
Well presumably you'd maybe want to localize them somewhere else and I could see multiple components wanting to use the strings in the future. Maybe that's premature, it just feels weird to have only this component ever know about how these values translate to something readable.
Primarily, these are: - Build script comments describing what is done - React style and nits
joselea
left a comment
joselea
left a comment
There was a problem hiding this comment.
This is a very long list of files, understandable since its the initial port of files. I couldn't find anything wrong that stands up other that what we discussed in the comments. I'm approving with the understanding that this project will continue to be develop and that next PRs will be smaller.
bgoddar
left a comment
bgoddar
left a comment
There was a problem hiding this comment.
Just a few nits here and there. Looks like a couple of places in your actions and reducers had some random empty lines added that don't seem intentional.
Didn't spend much time reviewing the UI sections either, let me know if you want me to go back, but based on the last local test I did I don't think I would find much that isn't already mentioned
packages/network-console-shared/src/collections/postman/v2.1/postman-2.1-schema.json
Show resolved
Hide resolved
- Changed the title editor to be editable on click (always a text box) instead of via a button - Removed the splitter button (Send and Download) and moved Download functionality into the response viewer - Moved Computed URL and response stats into Status Bar views in the request and response sides - Split off the address bar components so they don't touch, and restored their rounded corners - Matched FAST styling for the editor grids - removed vertical gridlines - Removed color for response status - Vertical splitter resize bar - switched to gray and removed the % difference overlay
- "Create new request" does not create a tab for it - Verb picker should not be free-form Dark theme: - Links should be consistently styled - "These parameters may contain sensitive information" in authorization warning is white on yellow. Violates CC requirements.
Also corrected a bug in which HTML previews wouldn't be displayed because they were blocked by CSP or the HTML content was too long.
Network Console is an experimental UI for creating synthetic HTTP requests from DevTools. It is designed for web API developers and consumers, and is intended to be compatible with similar tools.