Update due to merge conflicts, test memory leak issue

microsoft · Sep 24, 2024 · e2dd5c0 · e2dd5c0
1 parent 913c27e
commit e2dd5c0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/change/@microsoft-fast-foundation-e29676d4-d69a-4915-ae60-66ce6e649a92.json b/change/@microsoft-fast-foundation-e29676d4-d69a-4915-ae60-66ce6e649a92.json
@@ -0,0 +1,7 @@
+{
+ "type": "patch",
+ "comment": "Fix memory leak due to binding observers",
+ "packageName": "@microsoft/fast-foundation",
+ "email": "7282195+m-akinc@users.noreply.github.com",
+ "dependentChangeType": "patch"
+}
diff --git a/packages/web-components/fast-foundation/src/design-token/design-token.ts b/packages/web-components/fast-foundation/src/design-token/design-token.ts
@@ -704,6 +704,9 @@ class DesignTokenNode implements Behavior, Subscriber {
  const parent = childToParent.get(this)!;
  parent.removeChild(this);
  }
+ for (const token of this.bindingObservers.keys()) {
+ this.tearDownBindingObserver(token);
+ }
  }
 
  /**