-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flyout wc spec #3691
feat: add flyout wc spec #3691
Conversation
8da1a87
to
2289e08
Compare
9effb6a
to
cb65b1c
Compare
fde0ae9
to
329bd0d
Compare
This will close #3752 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
297a193
to
3e5ec69
Compare
3e5ec69
to
fa9e419
Compare
b94d24f
to
7e0fe97
Compare
@scomea does this satisfy your question and hold on this PR? |
@SethDonohue Yeah, the only thing I'm not clear about is how a user might configure the component to position itself based on available space (ie. below, but if if doesn't fit above) |
@scomea I actually forgot I already added a To me this says that unless they set Currently if I set |
This PR is very old now. What is our plan? We should close, move to draft, or get this in soon. |
One year old this week. /cc @chrisdholt |
This should be updated to align and leverage the Popover specification from Open-UI: openui/open-ui#355 Lots of research has now been gathered there and there is an editors draft available. We should update our spec accordingly from a naming standpoint as well as look to align the API to the current guidance there. At that point I think we can move ahead with implementation. Ideally, we should ensure we spell out in the spec that our preference is to use @SethDonohue do you want to rework this based on the above or close and we can look to kick off a new one given the deltas? |
Let's have a new one kicked off when ready! |
Description
Adds Flyout Web Component Spec
Motivation & context
FAST needs an Popover component as the Dialog does not currently cover cases where positioning is needed of a focusable floating container to display UI related to what the user is doing.
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist