-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: regenerate dependency graph to reduce module redundancies #4323
Conversation
- rebuild lockfile
- simplify storybook stories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 17540 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 17537 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit d6e6841 and detected 45 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Description
This PR draft should definitely be split apart before merging. It's just way too big to go in wholesale. I'm opening it to get discussion started on its parts so it can be more easily separated as we move forward with it.
This is a massive change that has very few actual moving parts. The bulk of it can be summarized as:
lodash
/lodash-es
,babel
, andeslint
as well as their related plugins and extensions. Aside frommonaco-editor
, this was the biggest culprit responsible the size explosion innode_modules
.yarn.lock
file. This is a controversial step, but since so many packages and projects have moved in and out of the repository in the last year, there were a lot of leftover extras that were being too aggressively specified, which lead to a reduction in overall hoisting opportunities.*.template.ts
and*.styles.ts
modules now have explicit types, which preventstsc
from generating declaration files withimport()
statements for types.any
,object
, and{}
types, which now throww errors when they're used.import type
statements. This is a feature that's been around since TypeScript 3.8, and is super nice.import "./something";
) and normalize naming for exports. This makes stories much simpler to write, since we don't have to use the modules to avoid tree-shaking.@typescript-eslint
from throwing errors in JavaScript files (which for us are mostly configuration files).To test this, please clean your local workspace entirely after checking out the branch:
Issue type checklist
Is this a breaking change?
I checked as much of the project as I could, but I'm not sure what the expected results are for every package in every part of the repository. Fingers crossed that I caught everything 🤞
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist