Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select border styles when control is active #5012

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Fix select border styles when control is active #5012

merged 3 commits into from
Jul 29, 2021

Conversation

claviska
Copy link
Contributor

Pull Request

📖 Description

Fixes a subtle style bug when the select component is active. In the GIF, observe any of the corners as the mouse is depressed.

Before
before

After
after

Not sure if this is something that makes sense to test for at this point — let me know what you think.

🎫 Issues

N/A

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@ghost
Copy link

ghost commented Jul 28, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @claviska!

@EisenbergEffect EisenbergEffect merged commit f4d1794 into microsoft:master Jul 29, 2021
@claviska claviska deleted the select-style-fix branch July 29, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants