Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add active id to accordion change event #6131

Merged
merged 3 commits into from
Jun 28, 2022
Merged

add active id to accordion change event #6131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa1540d
add activeid to accordion change event
chrisdholt Jun 20, 2022
634c50d
Change files
chrisdholt Jun 20, 2022
c613436
Merge branch 'master' into users/chhol/add-active-id-to-accordion-cha…
chrisdholt Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@microsoft-fast-foundation-788640ed-cd3b-4d9f-bedc-f179aae99903.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "add activeid to accordion change event",
"packageName": "@microsoft/fast-foundation",
"email": "chhol@microsoft.com",
"dependentChangeType": "patch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change this to "prerelease" also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dangit - I missed pushing this...PR incoming

}
2 changes: 1 addition & 1 deletion packages/web-components/fast-foundation/src/accordion/accordion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class Accordion extends FoundationElement {
private accordionIds: Array<string | null>;

private change = (): void => {
this.$emit("change");
this.$emit("change", this.activeid);
};

private findExpandedItem(): AccordionItem | null {
Expand Down