fix: accordion item should not collapse on unrelated change events #6158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scomea
requested review from
EisenbergEffect,
chrisdholt,
nicholasrice and
janechu
as code owners
|
|
scomea
changed the title
scomea
force-pushed
the
users/scomea/accordion-change-event-handling
branch
from
7d4dc05 to
e7ba0d0
Compare
EisenbergEffect
approved these changes
Jun 30, 2022
chrisdholt
approved these changes
Jun 30, 2022
chrisdholt
approved these changes
Jul 1, 2022
chrisdholt
pushed a commit
that referenced
this pull request
Aug 29, 2022
…6158) * Change files * prettier * add tests
chrisdholt
pushed a commit
that referenced
this pull request
Aug 29, 2022
…6158) * Change files * prettier * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Accordion was listening for
changeevents to determine when to open/close items, but was not differentiating between change events generated by the accordion items and those of the children of these items. This change adds checks to ensure that accordion ignoreschangeevents from other elements and does not react to events that have been defaultPrevented,🎫 Issues
closes #6144
📑 Test Plan
We should add some functional accordion tests when we move to playright. The current set is limited. Added an issue to track.
#6157
✅ Checklist
General
$ yarn changeComponent-specific