feat: [checkbox] implements open wc form control #6645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljefe223
requested review from
EisenbergEffect,
chrisdholt,
nicholasrice and
janechu
as code owners
eljefe223
changed the title
nicholasrice
reviewed
Mar 9, 2023
| "comment": "add open-wc form-control to fast-foundation", | ||
| "packageName": "@microsoft/fast-foundation", | ||
| "email": "jes@microsoft.com", | ||
| "dependentChangeType": "patch" |
There was a problem hiding this comment.
Suggested change
| "dependentChangeType": "patch" | |
| "dependentChangeType": "prerelease" |
eljefe223
force-pushed
the
users/jokreitl/open-wc-form-control
branch
2 times, most recently
from
2125947
to
6e1fa61
Compare
eljefe223
force-pushed
the
users/jokreitl/open-wc-form-control
branch
from
6e1fa61
to
b0f324a
Compare
scomea
reviewed
Apr 27, 2023
| public required: boolean = false; | ||
|
|
||
| public requiredChanged(): void { | ||
| this.setValue(this.value); |
There was a problem hiding this comment.
Why does changing required trigger a value update?
|
Closing this, due to #6951 we are only putting in critical fixes or features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Implements open-wc/form-control
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps