Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Exponential Notation in NumberField #6868

Closed
wants to merge 3 commits into from

Conversation

rizwan3d
Copy link

@rizwan3d rizwan3d commented Nov 19, 2023

The number field cautiously accepts multiple instances of "e," whereas the number system only permits a single occurrence of the same.

🎫 Issues

#6251

📑 Test Plan

11e1111 -> 11e1111
11e+1111 -> 11e+1111
11e-1111 -> 11e-1111
11e11.11 -> 11e1111
11e+11.11 -> 11e+1111
11e-11.11 -> 11e-1111
11e11e -> 11e11
11e111e1e1e1e1e1 -> 11e11111111
e -> empty
11e -> 11
e11 -> 0e11

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@radium-v
Copy link
Collaborator

I'd like to see a solution that allows for typing an exponential number as well - this only allows for programmatic insertion or copy-pasting into the field.

@rizwan3d rizwan3d changed the title Fix: multiple e in number-field Fix: Exponential Notation in NumberField Nov 27, 2023
@rizwan3d
Copy link
Author

@RaD

I'd like to see a solution that allows for typing an exponential number as well - this only allows for programmatic insertion or copy-pasting into the field.

Updated, can you please review it.

@janechu
Copy link
Collaborator

janechu commented Jun 14, 2024

Unfortunately, as part of #6951 we are closing out all outstanding foundation PRs and I believe this one was on hold due to the potential issues with using regex in this situation so it will be closed for now, I would suggest creating a custom element with this capability.

@janechu janechu closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants