-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(fast-todo-app): setup custom elements language server #6900
chore(fast-todo-app): setup custom elements language server #6900
Conversation
I want to just drop a note here, this is very interesting and we'll be checking back in after our launch of v2 for |
open-wc/custom-elements-manifest#276 Raised the breaking change at the analyser repo |
Hi @matteematt, sorry about the delay, we've had a lot of changes, I wanted to get your change and apply it to the |
# Pull Request ## 📖 Description This PR takes the changes from #6900 and applies them with some documentation and an update to the package lock instead of the previous yarn lock. Thanks @matteematt! We are moving our default branch from `master` to `main` but I wanted to get your change in here. If you'd like to add some additional info to our documentation site that would be 💯. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have included a change request file using `$ npm run change` - [ ] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](https://github.com/microsoft/fast/blob/master/CODE_OF_CONDUCT.md#our-standards) for this project.
Pull Request
📖 Description
Over the last six months we've been working on an LSP plugin for the
tsserver
which adds custom elements support in tagged template literals. The LSP is build to be extensible for different custom elements dialects, but we've added support for Microsoft FAST ourselves.This PR installs the LSP in the
todo-app
example repo as a showcase. This isn't necessarily the best showcase of the LSP due to the fact that this app doesn't use many custom elements, or any from dependencies. I am keen to install it more globally in the repo, or across more apps, dependening on whether you want this adding at all.🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
The way to test this depends on your IDE setup, and the way it works with the LSP. You can see in depth info for this here, but I assume you're using vscode so will provide some quick instrucitons below.
You can observe in
todo-app.template.ts
if you type a<
you'll get a suggestion for<todo-form>
✅ Checklist
General
$ yarn change
- Contributing guidelines state this is only necessary if you're changing files in thepackages/*
directory, which this PR is not.Component-specific
None of these
⏭ Next Steps
Happy to discuss or answer any questions you may have!