chore(fast-todo-app): setup custom elements language server #6900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Over the last six months we've been working on an LSP plugin for the
tsserver
which adds custom elements support in tagged template literals. The LSP is build to be extensible for different custom elements dialects, but we've added support for Microsoft FAST ourselves.This PR installs the LSP in the
todo-app
example repo as a showcase. This isn't necessarily the best showcase of the LSP due to the fact that this app doesn't use many custom elements, or any from dependencies. I am keen to install it more globally in the repo, or across more apps, dependening on whether you want this adding at all.🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
The way to test this depends on your IDE setup, and the way it works with the LSP. You can see in depth info for this here, but I assume you're using vscode so will provide some quick instrucitons below.
You can observe in
todo-app.template.ts
if you type a<
you'll get a suggestion for<todo-form>
✅ Checklist
General
$ yarn change
- Contributing guidelines state this is only necessary if you're changing files in thepackages/*
directory, which this PR is not.Component-specific
None of these
⏭ Next Steps
Happy to discuss or answer any questions you may have!