Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @microsoft/fast-foundation and @microsoft/fast-web-utilities #6996

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Jun 20, 2024

Pull Request

📖 Description

This change removes:

  • @microsoft/fast-foundation - the most recent version can be found on branch archives/fast-foundation-3
  • @microsoft/fast-web-utilities

🎫 Issues

Closes #6951 and closes #6954

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

  • File an issue to remove dependency on @microsoft/fast-foundation in @microsoft/fast-ssr for testing.

@radium-v
Copy link
Collaborator

Would it be possible to move fast-element, fast-router, and fast-ssr up one level to be directly in the packages/ directory? They're currently in packages/web-components/.

@chrisdholt
Copy link
Member

Would it be possible to move fast-element, fast-router, and fast-ssr up one level to be directly in the packages/ directory? They're currently in packages/web-components/.

I think this is a follow-up as part of the reorganization of the monorepo to npm workspaces (@janechu can correct me if I'm wrong)

@radium-v
Copy link
Collaborator

radium-v commented Jun 25, 2024

I'm getting an error when preparing and building from a clean state. I think @microsoft/site-utilities needs "@microsoft/fast-element": "^2.0.0-beta.26", in its dev dependencies.

Here's the error I'm seeing, only when running yarn in a clean state (no node_modules):

lerna info run Ran npm script 'prepare' in '@microsoft/site-utilities' in 0.5s:
yarn run v1.22.11
$ yarn generate:badges
$ node ./build/badges.js
Error: Cannot find module '/fast/node_modules/@microsoft/fast-element/dist/esm/index.js'
    at createEsmNotFoundErr (node:internal/modules/cjs/loader:1182:15)
    at finalizeEsmResolution (node:internal/modules/cjs/loader:1170:15)
    at resolveExports (node:internal/modules/cjs/loader:592:14)
    at Module._findPath (node:internal/modules/cjs/loader:669:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1131:27)
    at Function.resolve (node:internal/modules/helpers:190:19)
    at exports.getPackageJsonDir (/fast/build/get-package-json.js:17:27)
    at /fast/sites/site-utilities/build/badges.js:59:21
    at Array.map (<anonymous>)
    at Object.<anonymous> (/fast/sites/site-utilities/build/badges.js:57:29) {
  code: 'MODULE_NOT_FOUND',
  path: '/fast/node_modules/@microsoft/fast-element/package.json'
}
Done in 0.29s.

@janechu
Copy link
Collaborator Author

janechu commented Jun 25, 2024

Would it be possible to move fast-element, fast-router, and fast-ssr up one level to be directly in the packages/ directory? They're currently in packages/web-components/.

I think this is a follow-up as part of the reorganization of the monorepo to npm workspaces (@janechu can correct me if I'm wrong)

The issue with moving files like that wholesale is you lose the git history or at least it becomes very hard to track because you have to go back to before the commit where you moved things. If we feel that's not a big deal we can move things up a folder, I didn't want to do it without some discussion.

@janechu janechu merged commit 32446b8 into master Jun 26, 2024
10 checks passed
@janechu janechu deleted the users/janechu/remove-foundation-and-web-utils branch June 26, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of @microsoft/fast-web-utilities RFC: Removal of @microsoft/fast-foundation
3 participants