Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow xcode-project-file and info-plist params for codepush #318

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Allow xcode-project-file and info-plist params for codepush #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/fastlane/plugin/appcenter/actions/appcenter_codepush_release_react.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ def self.run(params)
private_key_path = params[:private_key_path]
dry_run = params[:dry_run]
use_local_appcenter_cli = params[:use_local_appcenter_cli]
plist_file = params[:plist_file]
xcode_project_file = params[:xcode_project_file]

base_executable = "appcenter "

Expand Down Expand Up @@ -66,6 +68,12 @@ def self.run(params)
if private_key_path
command += "--private-key-path #{private_key_path} "
end
if plist_file
command += "--plist-file #{plist_file} "
end
if xcode_project_file
command += "--xcode-project-file #{xcode_project_file} "
end
if dry_run
UI.message("Dry run!".red + " Would have run: " + command + "\n")
else
Expand Down Expand Up @@ -163,6 +171,16 @@ def self.available_options
optional: true,
default_value: false,
description: "When true, the appcenter cli installed in the project directory is used"),
FastlaneCore::ConfigItem.new(key: :plist_file,
type: String,
env_name: "APPCENTER_CODEPUSH_PLIST_FILE",
optional: true,
description: "Path to the Info.plist"),
FastlaneCore::ConfigItem.new(key: :xcode_project_file,
type: String,
env_name: "APPCENTER_CODEPUSH_XCODE_PROJECT_FILE",
optional: true,
description: "Path to the .pbxproj file"),
FastlaneCore::ConfigItem.new(key: :private_key_path,
type: String,
env_name: "APPCENTER_CODEPUSH_PRIVATE_KEY_PATH",
Expand Down