PR resource names include build number #1509
Conversation
| } | ||
| catch | ||
| {} | ||
| New-AzResourceGroup -Name "$(ResourceGroupName)" -Location "$(ResourceGroupRegion)" -Force |
There was a problem hiding this comment.
New-AzResourceGroup [](start = 10, length = 19)
Aren't this operation idempotent? Why we want drop resource group and everything in it? #Closed
There was a problem hiding this comment.
If the previous build didn't successfully complete the resource group from the last build will still be around. Before this change the old resources would be overwritten by the new ones since they would have the same name. Now new resources with different names will be added. To avoid pilling up a lot of resources in the resource group I added this to clean it up before the new resources are made. #Closed
There was a problem hiding this comment.
Make sense, on the same note, what happens to resources if someone closes PR for failed build? Are they automatically cleaned?
In reply to: 540447194 [](ancestors = 540447194)
There was a problem hiding this comment.
The build number is different for a few reasons, e.g.
If I have 1.0.1-pr1.1
I add a commit to fix my build => 1.0.1-pr1.2
Someone checks into master then I add a commit => 1.0.2-pr1.2
There was a problem hiding this comment.
If someone closes a PR with a failed build the resource group is not cleaned up. This is an open issue for us. I had added a script to cleanup a resource group when a PR was closed, but it wasn't working because the GithubAction to run AzureDevOps pipelines doesn't have a feature we need (Azure/pipelines#17) #Closed
build/pr-variables.yml
Outdated
| @@ -3,7 +3,8 @@ variables: | |||
| resourceGroupRoot: 'msh-fhir-pr' | |||
| appServicePlanName: '$(resourceGroupRoot)-$(prNumber)-asp' | |||
| prNumber: $(system.pullRequest.pullRequestNumber) | |||
| DeploymentEnvironmentName: '$(resourceGroupRoot)-$(prNumber)' | |||
| ResourceGroupName: '$(resourceGroupRoot)-$(prNumber)' | |||
| DeploymentEnvironmentName: '$(build.BuildNumber)' | |||
There was a problem hiding this comment.
. [](start = 39, length = 1)
looks like . is not allowed for keyvault name #Closed
There was a problem hiding this comment.
One of the other variables replaces them with dashes, I think it was $(GitVersion.NuGetVersionV2)
For reference: https://github.com/GitTools/actions/blob/master/gitversion/execute/action.yml
There was a problem hiding this comment.
That is super helpful! Thank you!
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -3,7 +3,8 @@ variables: | |||
| resourceGroupRoot: 'msh-fhir-pr' | |||
| appServicePlanName: '$(resourceGroupRoot)-$(prNumber)-asp' | |||
| prNumber: $(system.pullRequest.pullRequestNumber) | |||
| DeploymentEnvironmentName: '$(resourceGroupRoot)-$(prNumber)' | |||
| ResourceGroupName: '$(resourceGroupRoot)-$(prNumber)' | |||
| DeploymentEnvironmentName: 'f$(build.BuildNumber)' | |||
There was a problem hiding this comment.
f [](start = 32, length = 1)
why plain f is better than fhir? #Closed
There was a problem hiding this comment.
It is shorter. I'm running into issues with the full build number being too long for some resource types. There is a max name length of 24 characters. #Closed
Description
Changes the names of the resources created for testing a PR to include the build number in addition to the PR number.
Related issues
Previously we have encountered an error where resource names were conflicting with existing resources. This would require a new PR to be created as the names of the resources was based only on the PR number. This change will change the names of the resources on each build, allowing a rerun of the build to fix this issue.
Testing
Running the PR.
FHIR Team Checklist