Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Muted attribute doesn't work on Embed videos #1585

Closed
stuartlong opened this issue Jul 3, 2019 · 3 comments
Closed

Muted attribute doesn't work on Embed videos #1585

stuartlong opened this issue Jul 3, 2019 · 3 comments
Labels
vsts Paired with ticket in vsts

Comments

@stuartlong
Copy link
Member

Bug Report

Settings muted or muted={true} on Embed components doesn't actually mute them.

Steps

  1. Create an embed component
  2. Set it's source video as a mp4 video with sound
  3. Add muted={true} to the embed control

Expected Result

There should be a way to mute the component

Actual Result

Can't mute

Version

0.34.0

Testcase

https://codesandbox.io/s/stardust-ui-example-owdmg

@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Jul 4, 2019
@layershifter
Copy link
Member

muted is a prop of Video components, but this issue exists there, too: https://codesandbox.io/s/62dpz?module=/example.js

@stuartlong
Copy link
Member Author

stuartlong commented Jul 8, 2019

Right, yes, I don't expect Embed to take a specific muted attribute. But even setting the intrinsic muted attribute doesn't work.

@layershifter
Copy link
Member

Was fixed in #1847.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

3 participants