-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
} else { | ||
this.videoRef.current.removeAttribute('muted') | ||
} | ||
this.videoRef.current.muted = !!this.props.muted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
facebook/react#10389 (comment)
We should set muted
directly, setAttribute
only shows this attribute on DOM.
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
+ Coverage 69.64% 69.64% +<.01%
==========================================
Files 874 874
Lines 7612 7610 -2
Branches 2216 2215 -1
==========================================
- Hits 5301 5300 -1
+ Misses 2303 2302 -1
Partials 8 8
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
+ Coverage 69.64% 69.64% +<.01%
==========================================
Files 874 874
Lines 7612 7610 -2
Branches 2216 2215 -1
==========================================
- Hits 5301 5300 -1
+ Misses 2303 2302 -1
Partials 8 8
Continue to review full report at Codecov.
|
This PR fixes the
muted
prop onVideo
component, now it works properly.Tested in Chrome, FF, Edge and IE11.