This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(docs): display name for function components #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 716 716
Lines 8559 8559
Branches 1165 1165
=======================================
Hits 7028 7028
Misses 1515 1515
Partials 16 16Continue to review full report at Codecov.
|
layershifter
approved these changes
Mar 26, 2019
Generated by 🚫 dangerJS |
delete-merged-branch
bot
deleted the
fix/display-name-for-layout-docs-component
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is necessary to prevent crashes on rendering docs pages that contain code snippet with function components that have no display name. The crash is happening because of
No Display Nameused byreact-element-to-jsx-stringfor function components in prod:algolia/react-element-to-jsx-string#11
Fix is provided to the Layout guide page.